Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to new s2i native images introduced in Quarkus 2.14 #664

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Move to new s2i native images introduced in Quarkus 2.14 #664

merged 1 commit into from
Feb 6, 2023
+2 −1

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Jan 31, 2023 •
edited
Loading

Summary

Move to new builder images introduced in Quarkus 2.14

PR with the change - quarkusio/quarkus#27997

NEW is active - https://quay.io/quarkus/ubi-quarkus-native-binary-s2i
OLD is without update for 3 months - https://quay.io/quarkus/ubi-quarkus-native-s2i

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

I'll check OpenShiftS2iQuickstartUsingDefaultsIT.

@michalvavrik michalvavrik force-pushed the feature/fix-ubi-builder-image branch from 242094e to e951788 Compare February 2, 2023 09:25
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

I created quarkusio/quarkus#30829 for OpenShiftS2iQuickstartUsingDefaultsIT as I wasted loads of time on it and still don't have a clue where is the issue.

@michalvavrik michalvavrik force-pushed the feature/fix-ubi-builder-image branch from e951788 to 27e4edf Compare February 3, 2023 11:18
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

We won't upgrade s2i native image till upstream issue is resolved @fedinskiy .

@rsvoboda
Copy link
Member

rsvoboda commented Feb 3, 2023

So this PR is on hold?

@michalvavrik
Copy link
Member Author

No, I dropped changes in OpenShiftS2iGitRepositoryQuarkusApplicationManagedResource and now CI will pass, so once someone reviews it, it can be merged.

@michalvavrik
Copy link
Member Author

@rsvoboda ^^^

@rsvoboda
Copy link
Member

rsvoboda commented Feb 3, 2023

How do you plan to track the need to update OpenShiftS2iGitRepositoryQuarkusApplicationManagedResource ?

@michalvavrik
Copy link
Member Author

I'll know when issue is closed, tbh I expected imminent response but that was too optimistic. I can add a note though.. It means to wait for CI again, but I'll do that.

@rsvoboda
Copy link
Member

rsvoboda commented Feb 3, 2023

+1 to add TODO note

@rsvoboda
Copy link
Member

rsvoboda commented Feb 3, 2023

hm, OCP native run failed :/

@michalvavrik michalvavrik force-pushed the feature/fix-ubi-builder-image branch from 27e4edf to a4140b1 Compare February 3, 2023 13:57
@michalvavrik
Copy link
Member Author

added note

hm, OCP native run failed :/

native run number 245 is still running (I tested it locally too) and jvm run number 267 succeeded

@michalvavrik
Copy link
Member Author

245 succeeded

@rsvoboda rsvoboda requested a review from fedinskiy February 6, 2023 09:16
@fedinskiy fedinskiy merged commit cbeaee8 into quarkus-qe:main Feb 6, 2023
@michalvavrik michalvavrik deleted the feature/fix-ubi-builder-image branch February 6, 2023 10:30
@michalvavrik michalvavrik mentioned this pull request Feb 8, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedinskiy fedinskiy fedinskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalvavrik @rsvoboda @fedinskiy